세션 평가·라이브코치·교수자 분석 라운드 마감 + 문서 정리 + 코드품질 리팩터
- 누적 작업트리 커밋: 회기 평가 복구·durable 저장, 라이브 코치 이력/근거, 교수자 학생분석, 음성 비언어 메타, PII 마스킹, 운영 티켓/헬스 등 - 문서: 완료 기록 docs/archive/ 냉동 보관, docs/ 단일 인덱스(docs/README.md)+통합 TODO(docs/TODO.md)로 정리 - 리팩터(행위 보존): Stage enum SSOT(taxonomy 소유·state_machine re-export), store recent/masked_turns 중복 제거, speaker_ko_label 단일 헬퍼, _list_sessions N+1 제거(state/turns 배치 + 턴평가 하이드레이션 배치) - 검증: 백엔드 pytest 352 passed, _list_sessions E2E chromium-single-run 2 passed
This commit is contained in:
Yun Chan
parent
7c41c3ce79
commit
778e8526d4
108 changed files with 6457 additions and 455 deletions
|
|
@ -109,6 +109,38 @@ class ReevaluateSessionRouteTest(unittest.IsolatedAsyncioTestCase):
|
|||
|
||||
self.assertEqual(evaluate_session.await_args.kwargs["theory_mode"], "cbt")
|
||||
|
||||
async def test_reevaluate_session_uses_one_based_masked_turn_seq(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
sess = _session_stub()
|
||||
result = evaluator.SessionEvaluation(
|
||||
session_id=session_id,
|
||||
stage="정리",
|
||||
scope="session_end",
|
||||
turns_evaluated=2,
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(eval_routes, "_load_session_or_404", AsyncMock(return_value=sess)),
|
||||
patch.object(
|
||||
eval_routes.evaluator,
|
||||
"evaluate_session",
|
||||
AsyncMock(return_value=result),
|
||||
) as evaluate_session,
|
||||
patch.object(
|
||||
eval_routes.session_persistence,
|
||||
"save_session_evaluation",
|
||||
AsyncMock(return_value=True),
|
||||
),
|
||||
):
|
||||
await eval_routes.reevaluate_session(
|
||||
session_id,
|
||||
eval_routes.ReevaluateRequest(scope="session_end"),
|
||||
_teacher_principal(),
|
||||
)
|
||||
|
||||
masked_turns = evaluate_session.await_args.kwargs["masked_turns"]
|
||||
self.assertEqual([turn["seq"] for turn in masked_turns], [1, 2])
|
||||
|
||||
async def test_reevaluate_turn_preserves_session_theory_mode(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
sess = _session_stub(theory_mode="cbt", theory_target=["humanistic"], with_turns=True)
|
||||
|
|
@ -121,6 +153,11 @@ class ReevaluateSessionRouteTest(unittest.IsolatedAsyncioTestCase):
|
|||
"evaluate_turn",
|
||||
AsyncMock(return_value=result),
|
||||
) as evaluate_turn,
|
||||
patch.object(
|
||||
eval_routes.session_persistence,
|
||||
"replace_turn_evaluation",
|
||||
AsyncMock(return_value=True),
|
||||
) as replace_turn_evaluation,
|
||||
):
|
||||
await eval_routes.reevaluate_turn(
|
||||
session_id,
|
||||
|
|
@ -130,6 +167,119 @@ class ReevaluateSessionRouteTest(unittest.IsolatedAsyncioTestCase):
|
|||
|
||||
ctx = evaluate_turn.await_args.args[0]
|
||||
self.assertEqual(ctx.theory_mode, "cbt")
|
||||
replace_turn_evaluation.assert_awaited_once()
|
||||
self.assertEqual(
|
||||
replace_turn_evaluation.await_args.kwargs["turn_id"],
|
||||
"00000000-0000-0000-0000-00000000a001",
|
||||
)
|
||||
|
||||
async def test_reevaluate_turn_persists_result_for_review_hydration(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
sess = _session_stub(theory_mode="cbt", with_turns=True)
|
||||
result = evaluator.TurnEvaluation(
|
||||
turn_seq=1,
|
||||
stage="정리",
|
||||
theory_mode="cbt",
|
||||
appropriateness="pos",
|
||||
rapport_signal=0.4,
|
||||
techniques=[
|
||||
evaluator.TechniqueTag(
|
||||
code="empathy",
|
||||
label_ko="공감",
|
||||
category="relational",
|
||||
rationale="감정을 반영했다.",
|
||||
)
|
||||
],
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(eval_routes, "_load_session_or_404", AsyncMock(return_value=sess)),
|
||||
patch.object(
|
||||
eval_routes.evaluator,
|
||||
"evaluate_turn",
|
||||
AsyncMock(return_value=result),
|
||||
),
|
||||
patch.object(
|
||||
eval_routes.session_persistence,
|
||||
"replace_turn_evaluation",
|
||||
AsyncMock(return_value=True),
|
||||
) as replace_turn_evaluation,
|
||||
):
|
||||
response = await eval_routes.reevaluate_turn(
|
||||
session_id,
|
||||
eval_routes.TurnReevaluateRequest(turn_seq=1),
|
||||
_teacher_principal(),
|
||||
)
|
||||
|
||||
self.assertEqual(response.appropriateness, "pos")
|
||||
saved_payload = replace_turn_evaluation.await_args.kwargs["evaluation"]
|
||||
self.assertEqual(saved_payload["turn_seq"], 1)
|
||||
self.assertEqual(saved_payload["theory_mode"], "cbt")
|
||||
self.assertEqual(saved_payload["rapport_signal"], 0.4)
|
||||
self.assertEqual(saved_payload["techniques"][0]["label_ko"], "공감")
|
||||
self.assertEqual(sess.turns[0].evaluation, saved_payload)
|
||||
|
||||
async def test_reevaluate_turn_raises_when_result_cannot_be_saved(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
sess = _session_stub(with_turns=True)
|
||||
result = evaluator.TurnEvaluation(turn_seq=1, stage="정리")
|
||||
|
||||
with (
|
||||
patch.object(eval_routes, "_load_session_or_404", AsyncMock(return_value=sess)),
|
||||
patch.object(
|
||||
eval_routes.evaluator,
|
||||
"evaluate_turn",
|
||||
AsyncMock(return_value=result),
|
||||
),
|
||||
patch.object(
|
||||
eval_routes.session_persistence,
|
||||
"replace_turn_evaluation",
|
||||
AsyncMock(return_value=False),
|
||||
),
|
||||
):
|
||||
with self.assertRaises(HTTPException) as raised:
|
||||
await eval_routes.reevaluate_turn(
|
||||
session_id,
|
||||
eval_routes.TurnReevaluateRequest(turn_seq=1),
|
||||
_teacher_principal(),
|
||||
)
|
||||
|
||||
self.assertEqual(raised.exception.status_code, 503)
|
||||
self.assertIn("could not be saved", raised.exception.detail)
|
||||
|
||||
async def test_reevaluate_turn_saves_error_marker_then_raises(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
sess = _session_stub(with_turns=True)
|
||||
result = evaluator.TurnEvaluation(
|
||||
turn_seq=1,
|
||||
stage="정리",
|
||||
error="engine_error",
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(eval_routes, "_load_session_or_404", AsyncMock(return_value=sess)),
|
||||
patch.object(
|
||||
eval_routes.evaluator,
|
||||
"evaluate_turn",
|
||||
AsyncMock(return_value=result),
|
||||
),
|
||||
patch.object(
|
||||
eval_routes.session_persistence,
|
||||
"replace_turn_evaluation",
|
||||
AsyncMock(return_value=True),
|
||||
) as replace_turn_evaluation,
|
||||
):
|
||||
with self.assertRaises(HTTPException) as raised:
|
||||
await eval_routes.reevaluate_turn(
|
||||
session_id,
|
||||
eval_routes.TurnReevaluateRequest(turn_seq=1),
|
||||
_teacher_principal(),
|
||||
)
|
||||
|
||||
self.assertEqual(raised.exception.status_code, 503)
|
||||
self.assertEqual(raised.exception.detail, "engine_error")
|
||||
saved_payload = replace_turn_evaluation.await_args.kwargs["evaluation"]
|
||||
self.assertEqual(saved_payload["error"], "engine_error")
|
||||
|
||||
async def test_get_session_evaluation_exposes_status_error_and_durable_flag(self) -> None:
|
||||
session_id = "00000000-0000-0000-0000-00000000e222"
|
||||
|
|
@ -179,12 +329,14 @@ def _session_stub(
|
|||
turns = (
|
||||
[
|
||||
SimpleNamespace(
|
||||
turn_id="00000000-0000-0000-0000-00000000a001",
|
||||
turn_seq=1,
|
||||
speaker="counselor",
|
||||
text="상담자 발화",
|
||||
text_masked="상담자 발화",
|
||||
),
|
||||
SimpleNamespace(
|
||||
turn_id="00000000-0000-0000-0000-00000000a002",
|
||||
turn_seq=2,
|
||||
speaker="client",
|
||||
text="내담자 응답",
|
||||
|
|
@ -196,7 +348,10 @@ def _session_stub(
|
|||
)
|
||||
|
||||
def masked_turns(self):
|
||||
return [{"speaker": "counselor", "text_masked": "상담자 발화"}]
|
||||
return [
|
||||
{"speaker": "counselor", "text_masked": "상담자 발화"},
|
||||
{"speaker": "client", "text_masked": "내담자 응답"},
|
||||
]
|
||||
|
||||
return SessionStub()
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue