d3ro-voice/apps/desktop/tests/main/services/suggestion-presence.test.ts
Yun Chan f5ae4c8c04 feat(desktop): propose typo fixes inside the suggestion popup and make suggestions snappier
While suggestions are on, typos are no longer replaced silently. The popup shows
the fix next to the candidate and applies it only when the candidate is accepted.
The per-minute request cap rises from 6 to 20 so suggestions keep appearing after
accepting one and continuing to type.
2026-10-18 07:06:55 +09:00

216 lines
9.2 KiB
TypeScript

// 제안 창 반응성 — 빈 출력 재시도, 실패한 같은 글 재생성 방지, 멈추자마자 "생성 중" 자리 (2026-10-17)
//
// 실측: 문장 중간에서 공백 없이 끝난 prefill 은 gemma 가 곧바로 턴을 닫아 빈 출력이 됐고(18회 중 15회), 빈 출력마다
// 창을 닫은 뒤 같은 글로 1초마다 다시 생성해 "떴다 꺼졌다" 를 반복했다.
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
const config = vi.hoisted(() => ({
suggestionEnabled: true as boolean,
suggestionModelId: 'gemma4:e4b' as string | null,
llmModelId: 'gemma4:e4b' as string | null,
inputExcludedApps: [] as string[],
suggestionTriggerDelayMs: 600,
suggestionMinPrefixChars: 4,
suggestionMaxRequestsPerMinute: 20,
suggestionDailyBudget: 500,
suggestionRequestTimeoutMs: 8000,
inputLearnTypedText: false,
inputTelemetryEnabled: false,
suggestionOverlayInteractive: true,
insertMethod: 'clipboard'
}))
const harness = vi.hoisted(() => ({
streamGenerate: vi.fn(),
insertText: vi.fn(async (text: string) => ({ success: true, method: 'clipboard', textLength: text.length })),
replaceBeforeCaret: vi.fn(async (_count: number, text: string) => ({
success: true,
method: 'clipboard',
textLength: text.length
}))
}))
vi.mock('../../../src/main/services/ConfigService', () => ({
configGet: vi.fn((key: keyof typeof config) => config[key]),
configSet: vi.fn()
}))
vi.mock('../../../src/main/services/LoggerService', () => ({
getLogger: () => ({ info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() })
}))
vi.mock('../../../src/main/services/LocalLLMService', () => ({
getLocalLLMService: () => ({ isAvailable: () => true, streamGenerate: harness.streamGenerate })
}))
vi.mock('../../../src/main/services/InputTelemetryService', () => ({
getInputTelemetryService: () => ({ listPhrases: () => [], listRecentWrites: () => [] })
}))
vi.mock('../../../src/main/services/PersonalGraphService', () => ({
getPersonalGraphService: () => ({ retrieveContext: () => ({ continuations: [], related: [] }) })
}))
vi.mock('../../../src/main/services/TextInsertService', () => ({
getTextInsertService: () => ({ insertText: harness.insertText, replaceBeforeCaret: harness.replaceBeforeCaret })
}))
vi.mock('../../../src/main/services/modifier-state', () => ({ waitForModifiersReleased: async () => true }))
vi.mock('../../../src/main/utils/win32-foreground', () => ({ getForegroundWindowInfo: () => null }))
vi.mock('../../../src/main/db', () => ({ getDatabase: vi.fn() }))
vi.mock('../../../src/main/db/schema', () => ({ suggestions: {} }))
import {
SuggestionService,
type SuggestionServiceDeps
} from '../../../src/main/services/SuggestionService'
import { SuggestionBudget } from '../../../src/main/services/suggestion/SuggestionBudget'
import { ModelWarmTracker } from '../../../src/main/services/suggestion/ModelWarmTracker'
import type { TypingContext } from '../../../src/main/services/InputTelemetryService'
const PREFIX = '지금 테스트 해보는데 잠시 쉬면'
function typingContext(overrides: Partial<TypingContext> = {}): TypingContext {
const prefix = overrides.prefix ?? PREFIX
return {
prefix,
fullText: prefix,
caretOffset: prefix.length,
documentBefore: prefix,
anchor: { x: 10, y: 10, width: 2, height: 16 },
anchorKind: 'caret',
isPassword: false,
isEditable: true,
isComposing: false,
hasSelection: false,
available: true,
appName: 'notepad.exe',
windowTitle: 'notes',
windowHandle: null,
idleMs: 2000,
capturedAt: Date.now(),
editedSinceFocus: true,
typedRecently: true,
...overrides
}
}
function deps(): SuggestionServiceDeps {
const warmth = new ModelWarmTracker()
warmth.noteWarm('gemma4:e4b', Date.now() + 600_000)
return {
repository: { record: vi.fn(), markAccepted: vi.fn(), list: vi.fn(() => []) },
budget: new SuggestionBudget(),
warmth,
foreground: { currentWindowHandle: () => null },
learning: { expectProgrammaticInsert: vi.fn(() => vi.fn()), recordAccepted: vi.fn() }
}
}
interface Internal {
_generate(prefix: string, context: TypingContext, maxCandidates: number, maxChars: number): Promise<void>
_lastContext: TypingContext | null
_lastRequestAt: number
}
let services: SuggestionService[] = []
function create(): SuggestionService {
const service = new SuggestionService(deps())
services.push(service)
return service
}
beforeEach(() => {
harness.streamGenerate.mockReset()
})
afterEach(() => {
for (const service of services) service.dispose()
services = []
vi.useRealTimers()
})
describe('빈 출력 재시도', () => {
it('모델이 곧바로 턴을 닫으면 prefill 끝에 공백을 붙여 한 번 더 뽑고, 띄어 쓴 후보로 쓴다', async () => {
harness.streamGenerate.mockImplementation(async function* (prompt: string) {
yield prompt.endsWith(' ') ? '렉 걸리는 느낌이 있어.' : ''
})
const service = create()
;(service as unknown as Internal)._lastContext = typingContext()
await (service as unknown as Internal)._generate(PREFIX, typingContext(), 3, 160)
const prompts = harness.streamGenerate.mock.calls.map(([prompt]) => String(prompt))
expect(prompts[0].endsWith(PREFIX)).toBe(true)
expect(prompts[1].endsWith(`${PREFIX} `)).toBe(true)
expect(service.getState().candidates[0]).toEqual({ text: '렉 걸리는 느낌이 있어.', rank: 0 })
// 채우기도 공백 붙인 변형으로 보낸다
await vi.waitFor(() => expect(harness.streamGenerate.mock.calls.length).toBeGreaterThan(2))
expect(String(harness.streamGenerate.mock.calls[2][0]).endsWith(`${PREFIX} `)).toBe(true)
})
it('끝내 비면 창을 닫고, 같은 글로 멈춰 있는 동안 다시 생성하지 않는다 (더 치면 다시 한다)', async () => {
harness.streamGenerate.mockImplementation(async function* () {
yield ''
})
const service = create()
const context = typingContext()
service.handleTypingContext(context)
await vi.waitFor(() => expect(harness.streamGenerate).toHaveBeenCalledTimes(2))
await vi.waitFor(() => expect(service.getState().generating).toBe(false))
// 같은 글의 다음 스냅샷들 — 1.2초 간격이 지나도 다시 생성하지 않는다
vi.useFakeTimers({ now: Date.now() + 5000 })
service.handleTypingContext({ ...context, idleMs: 7000 })
service.handleTypingContext({ ...context, idleMs: 8000 })
expect(harness.streamGenerate).toHaveBeenCalledTimes(2)
expect(service.getState().generating).toBe(false)
vi.useRealTimers()
harness.streamGenerate.mockImplementation(async function* () {
yield ' 다음 문장.'
})
// 실제로는 더 치는 데 시간이 걸린다 — 요청 간격(1.2초)이 지난 것으로 둔다
;(service as unknown as Internal)._lastRequestAt = Date.now() - 5000
const longer = `${PREFIX} 그리고`
service.handleTypingContext(typingContext({ prefix: longer, documentBefore: longer, fullText: longer, caretOffset: longer.length }))
await vi.waitFor(() => expect(service.getState().candidates.length).toBeGreaterThan(0))
})
})
describe('멈추자마자 "생성 중" 자리', () => {
it('트리거 지연 전이라도 presenceDelayMs 가 지나면 생성 중으로 보이고, 생성은 아직 시작하지 않는다', () => {
const service = create()
const updates: boolean[] = []
service.on('updated', (state) => updates.push(state.generating))
service.handleTypingContext(typingContext({ idleMs: 400 }))
expect(service.getState().generating).toBe(true)
expect(service.getState().anchor).not.toBeNull()
expect(harness.streamGenerate).not.toHaveBeenCalled()
expect(updates).toEqual([true])
// 정책상 "표시 중" 은 아니다 — 생성 시점에 already-visible 로 막히면 안 된다
expect(service.isPresentationActive).toBe(false)
})
it('다시 치기 시작하면 조용히 거두고, 트리거 지연이 지나면 생성으로 이어진다', async () => {
harness.streamGenerate.mockImplementation(async function* () {
yield ' 이어지는 문장.'
})
const service = create()
service.handleTypingContext(typingContext({ idleMs: 400 }))
expect(service.getState().generating).toBe(true)
const typed = `${PREFIX}고`
service.handleTypingContext(typingContext({ prefix: typed, documentBefore: typed, fullText: typed, caretOffset: typed.length, idleMs: 80 }))
expect(service.getState().generating).toBe(false)
service.handleTypingContext(typingContext({ prefix: typed, documentBefore: typed, fullText: typed, caretOffset: typed.length, idleMs: 400 }))
expect(service.getState().generating).toBe(true)
service.handleTypingContext(typingContext({ prefix: typed, documentBefore: typed, fullText: typed, caretOffset: typed.length, idleMs: 800 }))
await vi.waitFor(() => expect(service.getState().candidates.length).toBeGreaterThan(0))
})
it('생성으로 이어지지 않으면 presenceMaxMs 뒤 스스로 거둔다', () => {
vi.useFakeTimers()
const service = create()
service.handleTypingContext(typingContext({ idleMs: 400 }))
expect(service.getState().generating).toBe(true)
vi.advanceTimersByTime(3100)
expect(service.getState().generating).toBe(false)
})
})