fix(desktop): resolve Ctrl+Alt+Enter accept drops and duplicate typo LLM checks
This commit is contained in:
parent
2a62f2496a
commit
02d0d0c6c1
15 changed files with 238 additions and 19 deletions
15
CHANGELOG.md
15
CHANGELOG.md
|
|
@ -12,6 +12,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||
- Additional Whisper model management UI
|
||||
- Plugin system for custom pipelines
|
||||
|
||||
## [1.15.3] - 2026-10-31
|
||||
|
||||
> Published from an annotated tag. Installer and update metadata are served by the
|
||||
> canonical Forgejo feed; no binaries are committed to this repository.
|
||||
|
||||
### Fixed
|
||||
- **`Ctrl + Alt + Enter` suggestion acceptance reliability (`@d3ro/core/keybinding-runtime`, `KeyBindingService`, `SuggestionService`, `bootstrap`).**
|
||||
- Fixes `ChordStateMachine.keyUp` so releasing a shared modifier (`Ctrl` or `RightAlt`) releases all held chords in `_isDown` that depend on that modifier instead of stopping after the first match (`command` `Ctrl+RightAlt`), preventing `suggestion-accept` (`Ctrl+Alt+Enter`) from remaining stuck in `_isDown` and silently dropping subsequent presses as auto-repeat.
|
||||
- Maps `UiohookKey.NumpadEnter` and numpad navigation keys in `UIOHOOK_TO_VK` and adds a 25 ms OS `globalShortcut` fallback trigger in `KeyBindingService._syncSuggestionCapture` so `Ctrl+Alt+Enter` still fires even if `uiohook` misses a key event.
|
||||
- Keeps OS suggestion shortcut capture active while the `"생성 중..."` pending indicator or an accept is in flight (`isOverlayOrCaptureActive`), and when `Ctrl+Alt+Enter` is pressed while candidate #1 is still streaming (`_inFlight` / `_generating` / `_pending`), waits up to 2.5 s for candidate #1 to finish and immediately accepts it instead of ignoring the key press.
|
||||
- **Duplicate typo-model check elimination (`TypoCorrectionService.propose`).**
|
||||
- Skips re-running `_askModel` in `TypoCorrectionService.propose` when `handleTypingContext` has already verified the same region (`_isRegionChecked(region)`), preventing a redundant 336-token LLM call during suggestion candidate filling from evicting Ollama's suggestion KV cache.
|
||||
|
||||
## [1.15.2] - 2026-10-31
|
||||
|
||||
> Published from an annotated tag. Installer and update metadata are served by the
|
||||
|
|
@ -22,7 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||
- Fixes `classifyKeyStroke` so modifier virtual keycodes (`0x10..0x12`, `0x5b..0x5c`, `0xa0..0xa5`) are classified as `'modifier'` before checking `modifiers.ctrl || modifiers.alt || modifiers.meta` (which `uiohook-napi` sets to `true` on the modifier keydown itself). Previously, pressing or holding `Ctrl` / `Alt` was misclassified as `'shortcut'` (`key=shortcut+C+A`), wiping out `TerminalKeystrokeTracker`'s active line buffer (`prefixLen=0`), clearing `_typedInCurrentFocus`, and triggering repeated UIA snapshots on every key-repeat tick.
|
||||
- Ignores standalone modifier keydowns and D3RO Voice's own `Ctrl+Alt` suggestion navigation/accept chords (`Ctrl+Alt+Up/Down/Left/Right/Enter/Space/Backspace`) in `InputTelemetryService._handleKeyDown` and `TerminalKeystrokeTracker.onKeyDown` without advancing `_inputRevision` / `_lastKeyAt` or resetting the tracked terminal line.
|
||||
- **Terminal suggestion acceptance without clipboard race (`SuggestionService._insertAccepted`).**
|
||||
- Uses direct Unicode keyboard injection (`insertMethod = 'keyboard'` via `SendInput(KEYEVENTF_UNICODE)`) instead of clipboard `Ctrl+V` when accepting a suggestion in terminal mode (`terminalMode === true`, including `xterm-helper-textarea`, `WindowsTerminal`, and `Kitedesk`), preventing delayed terminal paste processing from pasting the restored previous clipboard content (such as copied URLs) and synchronizing `TerminalKeystrokeTracker` via `applyProgrammaticReplacement`.
|
||||
- Uses direct Unicode keyboard injection (`insertMethod = 'keyboard'` via `SendInput(KEYEVENTF_UNICODE)`) instead of clipboard `Ctrl+V` when accepting a suggestion in terminal mode (`terminalMode === true` or `isTerminalApp(appName)`, including `xterm-helper-textarea`, `WindowsTerminal`, and `Kitedesk`), preventing delayed terminal paste processing from pasting the restored previous clipboard content (such as copied URLs) and synchronizing `TerminalKeystrokeTracker` via `applyProgrammaticReplacement`.
|
||||
- Stops the background candidate fill loop (`_fillRemainingCandidates`) immediately when `SuggestionService.accept()` is triggered so new candidates do not continue streaming while waiting for modifier release.
|
||||
- **UIA snapshot timer optimization (`InputTelemetryService._scheduleTextSnapshot`, `_readTextSnapshot`).**
|
||||
- Skips scheduling the 780 ms `_settleTimer` UIA snapshot on non-typing keys (`Enter`, `Arrow`, `Shortcut`, `Navigation`, `Function`, `Tab`) and automatically cancels any pending `_settleTimer` once the 380 ms `_textTimer` snapshot determines the field cannot trigger a suggestion (`prefixLen < minPrefixChars`, non-editable, or password), cutting redundant UIA bridge calls in half during everyday typing and navigation.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue