FlutterRgbaRendererPluginOnRgba gets rows padded to stride_align, and the pixel buffer has its own bytes per row ((width * 4 + 63) & ~63 on Apple Silicon). The frame was copied in one memcpy of len bytes, so rows came out shifted whenever the two differ: Kitedesk sends stride_align 1 for a session drawn in software, whose "all displays" view still uses textures, and any width that is not a multiple of 16 then shears (1366, 1001, 1279, 3838). A stride above the pixel buffer's wrote past its data. Rows are now copied one by one, width * 4 bytes each, when the strides differ, and in one memcpy of the rows otherwise. A frame shorter than its rows promise is dropped instead of being read past its end. Tests: rows_follow_the_frame_stride and short_frames_are_dropped pass; the other eight that failed still do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
101 lines
3.6 KiB
Swift
101 lines
3.6 KiB
Swift
//
|
|
// TextRgba.swift
|
|
// texture_rgba_renderer
|
|
//
|
|
// Created by kingtous on 2023/2/17.
|
|
//
|
|
// Modified by the Kitedesk fork (2026, T-4204): rows are copied one by one
|
|
// when their stride differs from the pixel buffer's.
|
|
//
|
|
|
|
import Foundation
|
|
import FlutterMacOS
|
|
import CoreVideo
|
|
|
|
@objc public class TextRgba: NSObject, FlutterTexture {
|
|
public var textureId: Int64 = -1
|
|
private var registry: FlutterTextureRegistry?
|
|
private var data: CVPixelBuffer?
|
|
private var width: Int = 0
|
|
private var height: Int = 0
|
|
private let queue = DispatchQueue(label: "text_rgba_sync_queue")
|
|
|
|
public static func new(registry: FlutterTextureRegistry?) -> TextRgba {
|
|
let textRgba = TextRgba()
|
|
textRgba.registry = registry
|
|
textRgba.textureId = registry?.register(textRgba) ?? -1
|
|
return textRgba
|
|
}
|
|
|
|
public func copyPixelBuffer() -> Unmanaged<CVPixelBuffer>? {
|
|
queue.sync {
|
|
if (data == nil) {
|
|
return nil
|
|
}
|
|
return Unmanaged.passRetained(data!)
|
|
}
|
|
}
|
|
|
|
private func _markFrameAvaliable(buffer: UnsafePointer<UInt8>, len: Int, width: Int, height: Int, stride_align: Int) -> Bool {
|
|
// The rows of buffer are padded to stride_align.
|
|
let row = width * 4
|
|
let stride = stride_align > 1 ? (row + stride_align - 1) / stride_align * stride_align : row
|
|
guard width > 0 && height > 0 && len >= stride * height else {
|
|
return false
|
|
}
|
|
var pixelBufferCopy: CVPixelBuffer?
|
|
// macOS only support 32BGRA currently.
|
|
let dict: [String: Any] = [
|
|
kCVPixelBufferPixelFormatTypeKey as String: kCVPixelFormatType_32BGRA,
|
|
kCVPixelBufferMetalCompatibilityKey as String: true,
|
|
kCVPixelBufferOpenGLCompatibilityKey as String: true,
|
|
// https://developer.apple.com/forums/thread/712709
|
|
kCVPixelBufferBytesPerRowAlignmentKey as String: 64
|
|
]
|
|
let result = CVPixelBufferCreate(kCFAllocatorDefault, width, height, kCVPixelFormatType_32BGRA, dict as CFDictionary, &pixelBufferCopy)
|
|
guard result == kCVReturnSuccess else {
|
|
return false
|
|
}
|
|
|
|
CVPixelBufferLockBaseAddress(pixelBufferCopy!, [])
|
|
let ptr = CVPixelBufferGetBaseAddress(pixelBufferCopy!)!
|
|
let bytesPerRow = CVPixelBufferGetBytesPerRow(pixelBufferCopy!)
|
|
if (bytesPerRow == stride) {
|
|
memcpy(ptr, buffer, stride * height)
|
|
} else {
|
|
for y in 0..<height {
|
|
memcpy(ptr + y * bytesPerRow, buffer + y * stride, row)
|
|
}
|
|
}
|
|
CVPixelBufferUnlockBaseAddress(pixelBufferCopy!, [])
|
|
self.data = pixelBufferCopy
|
|
self.width = width
|
|
self.height = height
|
|
if textureId != -1 && self.data != nil {
|
|
registry?.textureFrameAvailable(textureId)
|
|
return true
|
|
} else {
|
|
return false
|
|
}
|
|
}
|
|
|
|
@objc public func markFrameAvaliableRaw(buffer: UnsafePointer<UInt8>, len: Int, width: Int, height: Int, stride_align: Int) -> Bool {
|
|
queue.sync {
|
|
_markFrameAvaliable(buffer: buffer, len: len, width: width, height: height, stride_align: stride_align)
|
|
}
|
|
}
|
|
|
|
|
|
@objc public func markFrameAvaliable(data: Data, width: Int, height: Int, stride_align: Int) -> Bool {
|
|
data.withUnsafeBytes { buffer in
|
|
markFrameAvaliableRaw(
|
|
buffer: buffer.baseAddress!.assumingMemoryBound(to: UInt8.self),
|
|
len: data.count,
|
|
width: width,
|
|
height: height,
|
|
stride_align: stride_align)
|
|
}
|
|
}
|
|
}
|
|
|
|
|