Each session created a new TextureRgba and closeTexture never released it, so the engine's FlPixelBufferTexture kept its GL texture (one frame of GPU or, with llvmpipe, process memory per session). Releasing the object is not safe: FlPixelBufferTexture deletes its GL texture in dispose without selecting a GL context, so a release from another window deletes that window's texture of the same name (upstream PR #2 turned the remaining window white). closeTexture(key, recycle: true) now keeps the texture in a list of the plugin instance, i.e. of the engine (window) that created it, and the next createTexture of that engine registers it again. Its GL texture is only ever touched by that engine's populate in its own context, nothing is released, and the GL memory is bounded by the number of textures a window had open at once. When the engine goes away the recycled textures stay referenced for the same reason. Without recycle (old callers, or a tab that moves to another window while its session still holds the pointer) a closed texture stays terminated and is never handed out again. With no frame waiting, copy_pixels hands out one transparent pixel instead of no buffer, so a recycled texture cannot show the last frame of its previous session before the first new frame. Dart: closeTexture(int key, {bool recycle = false}) sends "recycle"; other platforms ignore it. Tests: all ten Linux lifecycle tests pass (clang and gcc, -Wall -Werror, also under ASan/UBSan); Dart 4/4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
60 lines
1.8 KiB
Dart
60 lines
1.8 KiB
Dart
// Modified by the Kitedesk fork (2026, B212): closeTexture takes `recycle`.
|
|
// ignore: unused_import, unnecessary_import
|
|
import 'dart:io';
|
|
// Compatible with lint in Flutter 3.0.5
|
|
// ignore: unused_import, unnecessary_import
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/services.dart';
|
|
|
|
import 'texture_rgba_renderer_platform_interface.dart';
|
|
|
|
/// An implementation of [TextureRgbaRendererPlatform] that uses method channels.
|
|
class MethodChannelTextureRgbaRenderer extends TextureRgbaRendererPlatform {
|
|
/// The method channel used to interact with the native platform.
|
|
@visibleForTesting
|
|
final methodChannel = const MethodChannel('texture_rgba_renderer');
|
|
|
|
@override
|
|
Future<String?> getPlatformVersion() async {
|
|
final version =
|
|
await methodChannel.invokeMethod<String>('getPlatformVersion');
|
|
return version;
|
|
}
|
|
|
|
@override
|
|
Future<int> createTexture(int key) async {
|
|
return await methodChannel
|
|
.invokeMethod<int>('createTexture', {"key": key}) ??
|
|
-1;
|
|
}
|
|
|
|
@override
|
|
Future<bool> closeTexture(int key, {bool recycle = false}) async {
|
|
return await methodChannel.invokeMethod<bool>(
|
|
'closeTexture', {"key": key, "recycle": recycle}) ??
|
|
false;
|
|
}
|
|
|
|
@override
|
|
Future<bool> onRgba(
|
|
int key, Uint8List data, int height, int width, int strideAlign) async {
|
|
return await methodChannel.invokeMethod<bool>('onRgba', {
|
|
"data": data,
|
|
"height": height,
|
|
"width": width,
|
|
"key": key,
|
|
"stride_align": strideAlign,
|
|
}) ??
|
|
false;
|
|
}
|
|
|
|
@override
|
|
Future<int> getTexturePtr(int key) async {
|
|
final ptr =
|
|
await methodChannel.invokeMethod('getTexturePtr', {"key": key}) ??
|
|
false;
|
|
return ptr;
|
|
}
|
|
}
|