B252: keep closed textures valid until the engine is done with them
Windows: closeTexture hands the texture to UnregisterTexture's callback and frees its frame buffers there; frames pushed after close are dropped. Without "recycle" the object is kept for the process lifetime (the session may still hold its pointer); an engine that shuts down keeps its open textures the same way. A duplicate createTexture key gets -1, getTexturePtr of an unknown key 0. macOS: closeTexture drops the frame and closes the texture to later frames; only "recycle" removes it from the plugin. Linux: the frame handed to the engine last is freed at that engine's next copy_pixels or once the engine has shut down, not at close: from Flutter 3.32 the raster thread can still be uploading it. Tests: windows/test/run_tests.sh (plain, --asan, --tsan) and linux/test/run_tests.sh (plain, --asan). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
8cd34a80ff
commit
f38b9420ac
15 changed files with 1388 additions and 31 deletions
|
|
@ -1,3 +1,7 @@
|
|||
// Modified by the Kitedesk fork (2026, B252): closeTexture keeps the texture
|
||||
// alive until the engine has unregistered it, and for good unless "recycle"
|
||||
// says that nothing pushes frames to its pointer any more.
|
||||
|
||||
#ifndef FLUTTER_PLUGIN_TEXTURE_RGBA_RENDERER_PLUGIN_H_
|
||||
#define FLUTTER_PLUGIN_TEXTURE_RGBA_RENDERER_PLUGIN_H_
|
||||
|
||||
|
|
@ -31,6 +35,8 @@ class TextureRgbaRendererPlugin : public flutter::Plugin {
|
|||
void HandleMethodCall(
|
||||
const flutter::MethodCall<flutter::EncodableValue> &method_call,
|
||||
std::unique_ptr<flutter::MethodResult<flutter::EncodableValue>> result);
|
||||
|
||||
void CloseTexture(std::unique_ptr<TextureRgba> texture, bool recycle);
|
||||
};
|
||||
|
||||
} // namespace texture_rgba_renderer
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue