B252: keep closed textures valid until the engine is done with them
Windows: closeTexture hands the texture to UnregisterTexture's callback and frees its frame buffers there; frames pushed after close are dropped. Without "recycle" the object is kept for the process lifetime (the session may still hold its pointer); an engine that shuts down keeps its open textures the same way. A duplicate createTexture key gets -1, getTexturePtr of an unknown key 0. macOS: closeTexture drops the frame and closes the texture to later frames; only "recycle" removes it from the plugin. Linux: the frame handed to the engine last is freed at that engine's next copy_pixels or once the engine has shut down, not at close: from Flutter 3.32 the raster thread can still be uploading it. Tests: windows/test/run_tests.sh (plain, --asan, --tsan) and linux/test/run_tests.sh (plain, --asan). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
8cd34a80ff
commit
f38b9420ac
15 changed files with 1388 additions and 31 deletions
|
|
@ -1,6 +1,7 @@
|
|||
// Modified by the Kitedesk fork (2026, B212): closeTexture with
|
||||
// Modified by the Kitedesk fork (2026, B212, B252): closeTexture with
|
||||
// "recycle": true keeps the texture for the next createTexture of the same
|
||||
// engine instead of leaking it.
|
||||
// engine instead of leaking it; an engine going away frees the frames its
|
||||
// closed textures showed last.
|
||||
|
||||
#include "include/texture_rgba_renderer/texture_rgba_renderer_plugin.h"
|
||||
#include "include/texture_rgba_renderer/texture_rgba_renderer.h"
|
||||
|
|
@ -131,6 +132,9 @@ static void texture_rgba_renderer_plugin_dispose(GObject *object)
|
|||
// purpose: releasing one makes the engine delete its GL texture in whatever
|
||||
// GL context is current, which can belong to another window.
|
||||
g_clear_pointer(&self->recycled, g_ptr_array_unref);
|
||||
// The engine shuts down before it releases its plugins, so it uploads no
|
||||
// frame any more.
|
||||
texture_rgba_free_retired_frames(self->texture_registrar);
|
||||
G_OBJECT_CLASS(texture_rgba_renderer_plugin_parent_class)->dispose(object);
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue