linux: recycle closed textures per engine, closeTexture(recycle:) (Kitedesk B212)
Each session created a new TextureRgba and closeTexture never released it, so the engine's FlPixelBufferTexture kept its GL texture (one frame of GPU or, with llvmpipe, process memory per session). Releasing the object is not safe: FlPixelBufferTexture deletes its GL texture in dispose without selecting a GL context, so a release from another window deletes that window's texture of the same name (upstream PR #2 turned the remaining window white). closeTexture(key, recycle: true) now keeps the texture in a list of the plugin instance, i.e. of the engine (window) that created it, and the next createTexture of that engine registers it again. Its GL texture is only ever touched by that engine's populate in its own context, nothing is released, and the GL memory is bounded by the number of textures a window had open at once. When the engine goes away the recycled textures stay referenced for the same reason. Without recycle (old callers, or a tab that moves to another window while its session still holds the pointer) a closed texture stays terminated and is never handed out again. With no frame waiting, copy_pixels hands out one transparent pixel instead of no buffer, so a recycled texture cannot show the last frame of its previous session before the first new frame. Dart: closeTexture(int key, {bool recycle = false}) sends "recycle"; other platforms ignore it. Tests: all ten Linux lifecycle tests pass (clang and gcc, -Wall -Werror, also under ASan/UBSan); Dart 4/4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
48fa1d7ddf
commit
8cd34a80ff
7 changed files with 106 additions and 12 deletions
|
|
@ -1,3 +1,4 @@
|
|||
// Modified by the Kitedesk fork (2026, B212): closeTexture takes `recycle`.
|
||||
import 'dart:typed_data';
|
||||
|
||||
export './texture_rgba_ffi.dart' show Native;
|
||||
|
|
@ -17,9 +18,15 @@ class TextureRgbaRenderer {
|
|||
|
||||
/// Close a texture with unique identifier [key].
|
||||
///
|
||||
/// Pass [recycle] = true only when nothing calls `onRgba` with the pointer
|
||||
/// from [getTexturePtr] any more. On Linux the texture is then kept for the
|
||||
/// next [createTexture] of the same window instead of being leaked
|
||||
/// (Kitedesk fork, B212); other platforms ignore it.
|
||||
///
|
||||
/// @return a boolean to indicate whether the operation is sucessfully executed.
|
||||
Future<bool> closeTexture(int key) {
|
||||
return TextureRgbaRendererPlatform.instance.closeTexture(key);
|
||||
Future<bool> closeTexture(int key, {bool recycle = false}) {
|
||||
return TextureRgbaRendererPlatform.instance
|
||||
.closeTexture(key, recycle: recycle);
|
||||
}
|
||||
|
||||
/// Provide the rgba data to the texture.
|
||||
|
|
|
|||
|
|
@ -1,3 +1,4 @@
|
|||
// Modified by the Kitedesk fork (2026, B212): closeTexture takes `recycle`.
|
||||
// ignore: unused_import, unnecessary_import
|
||||
import 'dart:io';
|
||||
// Compatible with lint in Flutter 3.0.5
|
||||
|
|
@ -30,9 +31,9 @@ class MethodChannelTextureRgbaRenderer extends TextureRgbaRendererPlatform {
|
|||
}
|
||||
|
||||
@override
|
||||
Future<bool> closeTexture(int key) async {
|
||||
return await methodChannel
|
||||
.invokeMethod<bool>('closeTexture', {"key": key}) ??
|
||||
Future<bool> closeTexture(int key, {bool recycle = false}) async {
|
||||
return await methodChannel.invokeMethod<bool>(
|
||||
'closeTexture', {"key": key, "recycle": recycle}) ??
|
||||
false;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1,3 +1,4 @@
|
|||
// Modified by the Kitedesk fork (2026, B212): closeTexture takes `recycle`.
|
||||
import 'dart:typed_data';
|
||||
|
||||
import 'package:flutter/foundation.dart';
|
||||
|
|
@ -35,7 +36,7 @@ abstract class TextureRgbaRendererPlatform extends PlatformInterface {
|
|||
throw UnimplementedError('createTexture() has not been implemented.');
|
||||
}
|
||||
|
||||
Future<bool> closeTexture(int key) {
|
||||
Future<bool> closeTexture(int key, {bool recycle = false}) {
|
||||
throw UnimplementedError('closeTexture() has not been implemented.');
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue