From 4bdb5b430e2d268056abfc18793534d23da91fa3 Mon Sep 17 00:00:00 2001 From: Kingtous Date: Sun, 19 Feb 2023 14:44:08 +0800 Subject: [PATCH] fix: memory leak on Linux --- linux/include/texture_rgba_renderer/texture_rgba_renderer.h | 2 +- linux/texture_rgba_renderer_plugin.cc | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/linux/include/texture_rgba_renderer/texture_rgba_renderer.h b/linux/include/texture_rgba_renderer/texture_rgba_renderer.h index 9944c2d..2c58ab4 100644 --- a/linux/include/texture_rgba_renderer/texture_rgba_renderer.h +++ b/linux/include/texture_rgba_renderer/texture_rgba_renderer.h @@ -54,13 +54,13 @@ static gboolean texture_rgba_populate(FlTextureGL *texture, // Note that Flutter only accepts textures in GL_RGBA8 format. glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, self->video_width, self->video_height, 0, GL_RGBA, GL_UNSIGNED_BYTE, self->buffer); + delete[] self->buffer; self->buffer = nullptr; g_mutex_unlock(&self->mutex); *target = GL_TEXTURE_2D; *name = self->texture_id; *width = self->video_width; *height = self->video_height; - return TRUE; } diff --git a/linux/texture_rgba_renderer_plugin.cc b/linux/texture_rgba_renderer_plugin.cc index 49c5543..6a36343 100644 --- a/linux/texture_rgba_renderer_plugin.cc +++ b/linux/texture_rgba_renderer_plugin.cc @@ -65,8 +65,8 @@ static void texture_rgba_renderer_plugin_handle_method_call( if (self->g_renderer_map->find(key) != self->g_renderer_map->end()) { fl_texture_registrar_unregister_texture(self->texture_registrar, FL_TEXTURE((*self->g_renderer_map)[key])); + self->g_renderer_map->erase(key); } - self->g_renderer_map->erase(key); response = FL_METHOD_RESPONSE(fl_method_success_response_new(fl_value_new_bool(true))); } else if (strcmp(method, "onRgba") == 0) @@ -169,6 +169,9 @@ extern "C" { priv->buffer_length = 4 * width * height; auto copied_data = new uint8_t[priv->buffer_length]; memcpy(copied_data, buffer, priv->buffer_length); + if (priv->buffer != nullptr) { + delete[] priv->buffer; + } priv->buffer = copied_data; priv->video_height = height; priv->video_width = width;