Commit graph

188 commits

Author SHA1 Message Date
hyranno
241b495f44 fix: driver.prepare_output_stream should take streams.input 2021-12-01 12:55:38 +09:00
est31
8e616c3dd9 Update alsa and nix dependencies
Also fixes the build.
2021-10-31 23:37:27 +01:00
Tatsuyuki Ishi
03947afefb wasapi: Allow both threading models and switch the default to STA
COM can prevent undefined behavior in either concurrency model by
performing marshaling when necessary. As a result, CoInitializeEx can be
called with either concurrency model, and in this case STA provides better
compatibility with other code requiring STA, e.g. ASIO backend or winit
drag-and-drop.

To dive into the detail, the entry point of WASAPI, MMDeviceEnumerator, is
registered with "both" threading model, which means that COM objects are
created with whatever the thread's concurrency model is set to. This raises
the concern that when STA is used, marshaling might make audio buffer
operations block on the main thread, breaking continuous audio processing.
However, the implementation actually uses free-threaded marshaller for
interfaces dealing with buffer operations, which effectively bypasses COM's
compatibility marshaling behavior and perform any API calls on the caller's
thread instead. Therefore, the interfaces would operate just fine on either
concurrency model.

For more details on COM's threading model, see [1].

[1] https://thrysoee.dk/InsideCOM+/ch04d.htm

Co-Authored-By: Henrik Rydgård <hrydgard@gmail.com>

Close #59
Close #348
Close #504
Close #530
Close #538
Close #572
2021-08-08 12:03:18 +09:00
Rémi Lauzier
ba462dad18
Fix some typo and warnings 2021-06-29 11:30:26 -04:00
Rémi Lauzier
6c78dce4c1
fix some clippy warnings 2021-06-25 18:07:05 -04:00
Alex Moon
c349eb1477 [ALSA] Improve stream setup parameters.
* Always set period before setting buffer size, even if
  `BufferSize::Fixed`.
* Set `start_threshold` based on `alsa::Direction` to avoid underruns on
  playback streams.

Also refactor the return values of the set params functions to reflect their
actual use and resolve some clippy warnings (including a logic error in
`stream_timestamp()`).
2021-06-17 17:09:26 +02:00
est31
47ef62d413
Merge pull request #567 from RustyDAW/jack-alloc
Update to rust-jack 0.7 and simplify implementation
2021-06-07 08:47:18 +02:00
Marko Mijalkovic
d6236adb84 Remove unimplemented size hint 2021-05-11 18:21:06 -04:00
Roope Salmi
833acbae61 Update to rust-jack 0.7 and simplify implementation
With rust-jack 0.7, the buffer_size callback is moved to
ProcessHandler. This reflects how it is actually called by jack:
it is called synchronously on the process thread, but it is allowed to
perform non-real-time-safe operations. In CPAL, this means that
it is fine to reallocate the temporary interlacing buffers when buffer
size changes.

This removes the need for buffer splitting on the output stream type,
and prevents panics when buffer size is made larger than initially on
the input stream type. (for some reason, buffer splitting was not
implemented for input previously)
2021-04-04 03:53:25 +03:00
est31
5837ceb58f
Merge pull request #562 from JCapucho/fix-alsa-distortion
Fix alsa in some configs outputting bad audio
2021-03-29 11:38:20 +02:00
Marcel Märtens
a945d83ac7 give each thread a unique name 2021-03-22 11:06:15 +01:00
Marcel Märtens
f9720b9767 clippy fixes 2021-03-22 10:59:08 +01:00
João Capucho
52821d9c37
Fix alsa in some configs outputting bad audio
This was introduced in 6b91485 and could cause issues with some alsa
configurations like that of pipewire-alsa which caused the audio to be
become weirdly distorted
2021-03-19 22:04:32 +00:00
Michael Hills
b9b36d6a9a iOS default sample rate pulled from audio unit 2021-01-02 02:04:13 +11:00
Michael Hills
2cccf99d50 Refactor coreaudio host and add iOS support + ios-feedback example 2021-01-02 02:04:13 +11:00
Alex Moon
9c4e240a7c Further refactoring of DeviceHandles.
Also fixes rustaudio/cpal#515.
2020-12-09 08:38:25 -07:00
Alex Moon
b89df31797 Refactor ALSA handle manipulation into methods on DeviceHandles. 2020-12-07 16:16:50 -07:00
Alex Moon
fb30d291ce Avoid calling alsa::PCM::new() multiple times.
Ensures that alsa::PCM::new() is called only once for a given Device so that we are
not rapidly opening and closing ALSA devices.
2020-11-18 10:22:41 -07:00
est31
a65e028412 Update alsa requirement to 0.4.3 and change io to io_bytes 2020-11-08 21:34:20 +01:00
Sergej Jurečko
3d163c3468 fix panic on windows if device gets unplugged 2020-11-05 09:24:00 +01:00
mitchmindtree
2220f58491
Merge pull request #491 from creator-rs/master
Add Android APK build CI and Release version 0.13.0
2020-11-03 13:03:47 +01:00
enfipy
bf766c1d5d
Update oboe to newest version. Fix support of input/output oboe streams 2020-10-29 19:32:11 +02:00
mitchmindtree
c3fce0bc7b
Merge pull request #452 from darakshan/master
Eliminate or suppress Clippy messages.
2020-10-27 23:36:28 +01:00
mitchmindtree
70408a92ec
Merge pull request #478 from dheijl/master
Re-enable WasApi loopback capture
2020-10-27 23:33:44 +01:00
mitchmindtree
f8775b1e7b
Merge pull request #468 from endragor/android-support
Android support via Oboe
2020-10-27 12:26:33 +01:00
dheijl
621d99ba56
Merge pull request #4 from RustAudio/master
Sync with rustaudio cpal
2020-10-25 12:53:30 +01:00
Johnny Egeland
43d7363aa2 Fixed error in sub-second nanos calculation which caused overflow panic 2020-10-25 11:15:54 +01:00
Ruslan Mustakov
4e9d27266c Android support via Oboe 2020-10-24 15:42:21 +07:00
dheijl
f4621de3a3
Merge pull request #2 from RustAudio/master
JACK Host (#389)
2020-10-01 12:35:40 +02:00
Erik Natanael Gustafsson
2b31fe41af
JACK Host (#389)
Co-authored-by: Federico Dolce <psykopear@gmail.com>
2020-10-01 18:04:43 +09:00
dheijl
1e9689ef48 rust format --all 2020-09-20 17:00:51 +02:00
dheijl
0d37421b45 rust format 2020-09-20 16:01:59 +02:00
dheijl
1f4d7b04c9
Merge pull request #1 from RustAudio/master
Merge with Rustaudio/cpal
2020-09-12 12:53:46 +02:00
est31
5fec80e344
Merge pull request #470 from exrook/master
Handle ALSA overruns/underruns by resetting the PCM device
2020-09-11 20:57:58 +02:00
Rob Watson
0b300afefe wasm backends: Avoid a heap allocation in default_output_config() 2020-09-11 11:39:43 +02:00
Rob Watson
b5b6014edf wasm backends: Fix default_output_config behaviour 2020-09-11 09:29:00 +02:00
dheijl
78e8452150 Reenable WasApi loopback 2020-09-10 15:32:18 +02:00
Jacob Hughes
6b91485781 ALSA: Fix 100% CPU usage after underrun
With my previous patch, after an underrun occurred sometimes polling the
alsa FDs would always return POLLIN immediately, but avail_frames would
be zero. Eventually avail_frames would become nonzero and audio output
would work, but poll would still return immediately afterwards.

Calling `stream.prepare()` when this happens seems to fix the issue after
a few loops.
2020-09-01 12:31:06 -04:00
Jacob Hughes
119ada803e Handle ALSA overruns/underruns by resetting the PCM device 2020-08-31 14:20:24 -04:00
Richard Mitic
cb49e4446c Use alsa::pcm::Frames in alsa API calls instead of fixed-width integers.
`alsa::pcm::Frames` resolves to `c_long` which is 32 bits when compiling
for raspberry pi (armv7l).
2020-07-27 14:18:41 +02:00
Darakshan Farber
7d35b7d448 rustfmt 2020-07-21 17:59:53 -07:00
Darakshan Farber
17e079d15d Eliminate or suppress Clippy messages. 2020-07-21 12:54:49 -07:00
Rob Watson
8a3dc611fa Fix compilation warnings 2020-07-14 22:05:55 +02:00
mitchmindtree
b78ff83c03
Merge pull request #401 from JoshuaBatty/buffersize_range
Prototyping an API for getting the supported min and max buffersizes
2020-07-14 14:35:46 +02:00
JoshuaBatty
e739dbf32d cargo fmt 2020-07-14 14:11:35 +02:00
JoshuaBatty
e854c4e54c added in sniperrifle2004 code from PR 431 2020-07-14 14:10:00 +02:00
JoshuaBatty
f285389002 fixed mismatched types in emscipten set_timeout 2020-07-14 13:51:49 +02:00
JoshuaBatty
4ce12a69b9 adds docs for BufferSize and fixes buffersize bugs in emscripten and alsa 2020-07-14 13:19:26 +02:00
Konstantin Baltruschat
b177bcdf22
Fix build error when cross compiling to 32bit targets (#430) 2020-06-17 16:21:31 +02:00
JoshuaBatty
271cc34f3f cargo fmt fix for coreaudio 2020-05-27 13:28:18 +02:00