From 90471506b17530cbab8e88022331c893d9ab6161 Mon Sep 17 00:00:00 2001 From: Ruairidh Williamson <43679745+RuairidhWilliamson@users.noreply.github.com> Date: Tue, 27 Dec 2022 22:25:02 +0000 Subject: [PATCH] Support i32 for asio (#737) --- src/host/asio/device.rs | 9 ++------- src/host/asio/stream.rs | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/host/asio/device.rs b/src/host/asio/device.rs index 7fc5dd7..f481635 100644 --- a/src/host/asio/device.rs +++ b/src/host/asio/device.rs @@ -209,13 +209,8 @@ pub(crate) fn convert_data_type(ty: &sys::AsioSampleType) -> Option SampleFormat::I16, sys::AsioSampleType::ASIOSTFloat32MSB => SampleFormat::F32, sys::AsioSampleType::ASIOSTFloat32LSB => SampleFormat::F32, - // NOTE: While ASIO does not support these formats directly, the stream callback created by - // CPAL supports converting back and forth between the following. This is because many ASIO - // drivers only support `Int32` formats, while CPAL does not support this format at all. We - // allow for this implicit conversion temporarily until CPAL gets support for an `I32` - // format. - sys::AsioSampleType::ASIOSTInt32MSB => SampleFormat::I16, - sys::AsioSampleType::ASIOSTInt32LSB => SampleFormat::I16, + sys::AsioSampleType::ASIOSTInt32MSB => SampleFormat::I32, + sys::AsioSampleType::ASIOSTInt32LSB => SampleFormat::I32, _ => return None, }; Some(fmt) diff --git a/src/host/asio/stream.rs b/src/host/asio/stream.rs index 29229e2..a68b937 100644 --- a/src/host/asio/stream.rs +++ b/src/host/asio/stream.rs @@ -605,7 +605,7 @@ fn check_config( } // unsigned formats are not supported by asio match sample_format { - SampleFormat::I16 | SampleFormat::F32 => (), + SampleFormat::I16 | SampleFormat::I32 | SampleFormat::F32 => (), _ => return Err(BuildStreamError::StreamConfigNotSupported), } if *channels > num_asio_channels {