From 6c78dce4c1a40356bf8f9df7204cce82e07adcdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Lauzier?= Date: Fri, 25 Jun 2021 17:56:34 -0400 Subject: [PATCH] fix some clippy warnings --- src/host/alsa/mod.rs | 2 +- src/host/jack/device.rs | 20 +++++--------------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/src/host/alsa/mod.rs b/src/host/alsa/mod.rs index f53f2b7..fa2b35a 100644 --- a/src/host/alsa/mod.rs +++ b/src/host/alsa/mod.rs @@ -317,7 +317,7 @@ impl Device { Ok(handle) => handle, }; - let hw_params = alsa::pcm::HwParams::any(&handle)?; + let hw_params = alsa::pcm::HwParams::any(handle)?; // TODO: check endianess const FORMATS: [(SampleFormat, alsa::pcm::Format); 3] = [ diff --git a/src/host/jack/device.rs b/src/host/jack/device.rs index a98d813..f662df1 100644 --- a/src/host/jack/device.rs +++ b/src/host/jack/device.rs @@ -121,24 +121,18 @@ impl Device { min_sample_rate: f.sample_rate, max_sample_rate: f.sample_rate, buffer_size: f.buffer_size.clone(), - sample_format: f.sample_format.clone(), + sample_format: f.sample_format, }); } supported_configs } pub fn is_input(&self) -> bool { - match self.device_type { - DeviceType::InputDevice => true, - _ => false, - } + matches!(self.device_type, DeviceType::InputDevice) } pub fn is_output(&self) -> bool { - match self.device_type { - DeviceType::OutputDevice => true, - _ => false, - } + matches!(self.device_type, DeviceType::OutputDevice) } } @@ -202,9 +196,7 @@ impl DeviceTrait for Device { Ok(c) => client = c, Err(e) => { return Err(BuildStreamError::BackendSpecific { - err: BackendSpecificError { - description: e.to_string(), - }, + err: BackendSpecificError { description: e }, }) } }; @@ -243,9 +235,7 @@ impl DeviceTrait for Device { Ok(c) => client = c, Err(e) => { return Err(BuildStreamError::BackendSpecific { - err: BackendSpecificError { - description: e.to_string(), - }, + err: BackendSpecificError { description: e }, }) } };