test(wasapi): identify released events without handle reuse races
This commit is contained in:
parent
20fc4e430e
commit
2738d2077a
1 changed files with 34 additions and 13 deletions
|
|
@ -1,19 +1,29 @@
|
||||||
use super::*;
|
use super::*;
|
||||||
use crate::traits::{DeviceTrait, HostTrait};
|
use crate::traits::{DeviceTrait, HostTrait};
|
||||||
use std::time::{Duration, Instant};
|
use std::{
|
||||||
|
ffi::CString,
|
||||||
|
time::{Duration, Instant},
|
||||||
|
};
|
||||||
|
|
||||||
const WORKER_DEADLINE: Duration = Duration::from_secs(2);
|
const WORKER_DEADLINE: Duration = Duration::from_secs(2);
|
||||||
|
|
||||||
|
#[derive(Debug)]
|
||||||
enum WorkerExit {
|
enum WorkerExit {
|
||||||
Termination,
|
Termination,
|
||||||
Finished,
|
Finished,
|
||||||
Panicked,
|
Panicked,
|
||||||
}
|
}
|
||||||
|
|
||||||
fn stream(exit: WorkerExit) -> (Stream, Foundation::HANDLE) {
|
fn stream(exit: WorkerExit) -> (Stream, CString) {
|
||||||
let event =
|
let name = CString::new(format!(
|
||||||
unsafe { Threading::CreateEventA(None, false, false, windows::core::PCSTR(ptr::null())) }
|
"Local\\cpal-lifecycle-{}-{exit:?}",
|
||||||
.unwrap();
|
std::process::id()
|
||||||
|
))
|
||||||
|
.unwrap();
|
||||||
|
let event = unsafe {
|
||||||
|
Threading::CreateEventA(None, false, false, windows::core::PCSTR(name.as_ptr() as _))
|
||||||
|
}
|
||||||
|
.unwrap();
|
||||||
let (tx, rx) = channel();
|
let (tx, rx) = channel();
|
||||||
let wait_for_exit = !matches!(exit, WorkerExit::Termination);
|
let wait_for_exit = !matches!(exit, WorkerExit::Termination);
|
||||||
let worker = thread::spawn(move || match exit {
|
let worker = thread::spawn(move || match exit {
|
||||||
|
|
@ -38,19 +48,30 @@ fn stream(exit: WorkerExit) -> (Stream, Foundation::HANDLE) {
|
||||||
commands: tx,
|
commands: tx,
|
||||||
pending_scheduled_event: owned_event,
|
pending_scheduled_event: owned_event,
|
||||||
},
|
},
|
||||||
event,
|
name,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn assert_event_closed(exit: WorkerExit) {
|
fn assert_event_closed(exit: WorkerExit) {
|
||||||
let (stream, event) = stream(exit);
|
let (stream, name) = stream(exit);
|
||||||
let mut flags = 0;
|
|
||||||
unsafe { Foundation::GetHandleInformation(event, &mut flags) }.unwrap();
|
|
||||||
drop(stream);
|
drop(stream);
|
||||||
assert!(
|
// Another test can reuse a closed handle value; check the event's identity instead.
|
||||||
unsafe { Foundation::GetHandleInformation(event, &mut flags) }.is_err(),
|
match unsafe {
|
||||||
"Stream destruction leaked its command event"
|
Threading::OpenEventA(
|
||||||
);
|
Threading::EVENT_MODIFY_STATE,
|
||||||
|
false,
|
||||||
|
windows::core::PCSTR(name.as_ptr() as _),
|
||||||
|
)
|
||||||
|
} {
|
||||||
|
Ok(event) => {
|
||||||
|
let _event = unsafe { OwnedHandle::from_raw_handle(event.0 as _) };
|
||||||
|
panic!("Stream destruction leaked its command event");
|
||||||
|
}
|
||||||
|
Err(error) => assert_eq!(
|
||||||
|
error.code(),
|
||||||
|
windows::core::HRESULT::from_win32(Foundation::ERROR_FILE_NOT_FOUND.0),
|
||||||
|
),
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue